Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - Change representation of cost models in the code to JSON string #505

Open
carbolymer opened this issue Apr 3, 2024 · 6 comments
Open

Comments

@carbolymer
Copy link
Contributor

carbolymer commented Apr 3, 2024

Internal/External
Internal

Area
Other Any other topic (Delegation, Ranking, ...).

Describe the feature you'd like
Currently cost models are represented as an array with hard to understand values. To make maintenance easier, they should be stored as JSON string in haskell (quasiquoted preferably). The cost model should be also linked to the original location in plutus repository in the code comment: https://github.com/IntersectMBO/plutus/blob/master/plutus-core/cost-model/data/builtinCostModel.json

A validation logic implemented in cardano-testnet would be nice to have: https://github.com/IntersectMBO/cardano-node/blob/cd3c037fa6d2f836794012f806cd32edfcf31763/cardano-testnet/src/Testnet/Defaults.hs#L88

Describe alternatives you've considered
n/a

Additional context / screenshots
n/a

@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Apr 3, 2024

haskell (quasiquoted preferably)

We could also store it as a list we will mconcat:

mconcat [ "parameterName: ", show @Int 123456
        , ...
        ]

This comment was marked as off-topic.

@github-actions github-actions bot added the Stale label May 4, 2024
@carbolymer carbolymer removed the Stale label May 6, 2024

This comment was marked as off-topic.

@github-actions github-actions bot added the Stale label Jun 6, 2024

This comment was marked as off-topic.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
@carbolymer carbolymer reopened this Oct 7, 2024
@github-actions github-actions bot removed the Stale label Oct 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@carbolymer carbolymer removed the Stale label Nov 12, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

@github-actions github-actions bot added the Stale label Dec 13, 2024
@smelc smelc removed the Stale label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants