-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How can I make a safeFrame responsive? #20
Comments
In the Yahoo version, it takes an aspect ratio for width/height settings to do just that, but I'm not sure the reference implementation has that. I've never gone back to adding all the extra stuff that we added when i was at Yahoo, mainly for lack of time. . . You can probably do that or just allow % width/heights. The tricky part is that inside the frame you also need to know the configuration is using % b/c the baseline HTML has to change a bit so that 100%/100% on the HTML/BODY tag will work (main tag needs to be relative or statically positioned). |
I don't think the host can configure the iframe to use % because according to the doc:
Not sure if the only way to achieve this is to use the expand functionality? |
Yeah I know what's in the spec, but like I said earlier in the Yahoo version we expanded that further, that version accepts aspect ratio (which converts to 100% width + corresponding % of for height). As noted though we never got around to putting that in to the reference implementation |
Ah, got you. Thanks for your quick response! |
Is there a way to implement the safeFrame to be responsive? if so, can you provide an example on how I can achieve this? Right now, all the content just gets hidden, if I resize the browser.
The text was updated successfully, but these errors were encountered: