Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblock Plus "Disable on this Site only" with wrong detection (sometimes) #1

Open
christianhaller opened this issue Apr 20, 2016 · 3 comments

Comments

@christianhaller
Copy link

christianhaller commented Apr 20, 2016

Hi,
the detection is not reliable, when the user has Adblock Plus (2.7.2) running in the mode "Disable on this page" only.

In the gif, you can see the race condition.

abp-bug

Actual result:
inconsistent

Expected result:
"Adblock is disabled"

Firefox 45, OS X 10.11.14

@christianhaller
Copy link
Author

cc @andrevollmer :)

@iabmayank
Copy link
Contributor

The script has been updated with the fix. Please checkout the latest code.
Note: The analytics script along with the fix will be update soon.

@marttihalme
Copy link

Hi,
what was actually changed or fixed?

Br,
Martti
Alma Media Finland

From: Mayank Mishra [mailto:[email protected]]
Sent: 27. kesäkuuta 2016 18:36
To: InteractiveAdvertisingBureau/AdBlockDetection [email protected]
Subject: Re: [InteractiveAdvertisingBureau/AdBlockDetection] Adblock Plus "Disable on this Site only" with wrong detection (sometimes) (#1)

The script has been updated with the fix. Please checkout the latest code.
Note: The analytics script along with the fix will be update soon.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/1#issuecomment-228783217, or mute the threadhttps://github.com/notifications/unsubscribe/AKhDGaRsxurQ3IDt8b8KHGZFh3SS1432ks5qP-3sgaJpZM4ILo6E.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants