This repository has been archived by the owner on May 13, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Add oneAPI DPC++ ESIMD extention as a new backend for T2S on GPU #21
Open
tanzelin430
wants to merge
17
commits into
IntelLabs:master
Choose a base branch
from
tanzelin430:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronghongbo
reviewed
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zelin, thanks for the great efforts. Overall, it looks good. There are many minor places to fix, though:
- OneAPI and DPC: we have both terms used in many places due to historical reasons. You may help clean up this mess. I would suggest you to change them into something like "DPC_GPU" and "DPC_FPGA", or "OneAPI_GPU" and "OneAPI_FPGA". But you can leave this as the next step, though.
- Halide/performance: what is the purpose of this directory? remove it if not needed
- Halide/preprocessor: same question as above
- Codegen_GPU_Host.cpp: 120: I would suggest to add "CM", "DPC/OneAPI_FPGA", "DPC/OneAPI_GPU" features to Halide/src/Target.h and check against them.
- Halide/src/CodeGen_LLVM.cpp: The debugging line is useless now after you made things work
- Halide/src/Module.h: 43: again, we have the mix-use of "DPC" and "OneAPI". They are the same and we should keep only one of them.
- Target.cpp: 666 and 669: Add something like WITH_DPC in Halide/Makefile, and change these lines correspondingly.
- Target.cpp: 690-694: if the else statement is not useful any more, remove it.
- Pipeline.cpp: make { after a statement so that the coding style is consistent with the rest of the system
- install-tool.sh: 24: can a common user uses "apt install"? I guess users do not necessarily have the root privilege to do that. Since python is popular and used everywhere, I would suggest to not install python. Instead, in README, just list python (2x or 3x) as a prerequisite.
- setenv.sh: keep the useful changes, and remove the dead ones.
- preprocessor: we need to move it to t2s/src, and also clean up the file names (like post.t2s.......) Currently Abe makes file names too long). We should make the file names consistent with the workflow.png shows
- preprocessor/sample: (1) the several samples have many generated files. They should not be checked in. (2) oneapi-target-4-parameters.h should be renamed into const-parameters.h? (3) HalideBuffer., buffer_t., HalideRuntime., runtime_internal. should all be removed. They can be found from Halide/src, Halide/src/runtime, etc. So in a command line, you can use "-I ..." to set include paths to include .h files, or add path_to_a_cpp_file/something.cpp, to make things work without such copies. (3) pipe_array* files are copied from https://oneapi.team/tattle/oneAPI-samples/-/tree/9d8b94a38f2a98042cf933adfb91ec1da3d5ad51/DirectProgramming/DPC++FPGA/Tutorials/DesignPatterns/pipe_array/src. Please add some command lines in install-tool.sh to achieve this effect, instead of hard copies. (4) Sample03/perf.cpp: is it still useful? (5) util.h can be included from t2s/tests/correctness/util. No need for another copy.
- tests/performance/capsule.cpp: it does not seem you have made any real change. Recover the original files if the only difference is format. I saw some other files having similar issues. You would like to minimize the number of files in your check in
- performance/capsule/const-parameters.h: why changing the parameters? That would invalidate the performance numbers we report.
- performance/gemm/const-parameters.h: same question as above
- performance/gemm/gemm-run-gpu-oneapi.cpp: is this file useful?
Please clean up the files based on the feedback, and let me take a look again. Thanks!
Xiaochen has merged your changes into his fork, and will push to main repo in future together with his changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.