Merge pull request #373 from InseeFr/sdmx-ruleset-error

Missing ruleset reference in the SDMX repository
InseeFr · Nov 29, 2024 · 0dbc473 · 0dbc473
2 parents 0fe9c6d + 0fc9bb7
commit 0dbc473
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java b/vtl-sdmx/src/test/java/fr/insee/vtl/SDMXVTLWorkflowTest.java
@@ -10,6 +10,7 @@
 import io.sdmx.utils.core.io.ReadableDataLocationTmp;
 import org.apache.spark.sql.SparkSession;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 
 import javax.script.ScriptContext;
@@ -30,6 +31,27 @@ public void setUp() {
         engine = mgr.getEngineByExtension("vtl");
     }
 
+    @Disabled
+    @Test
+    void testRefFromRepo() {
+        // Works partially, the transformation does not pull in the ruleset. Maybe the transformation is wrong and does not
+        // reference ruleset?
+        String url = "https://registry.sdmx.io/sdmx/v2/structure/transformationscheme/FR1/BPE_CENSUS/+/?format=sdmx-3.0&references=all";
+        ReadableDataLocation rdl = new ReadableDataLocationTmp(url);
+        SDMXVTLWorkflow sdmxVtlWorkflow = new SDMXVTLWorkflow(engine, rdl, Java8Helpers.mapOf());
+        System.out.println(sdmxVtlWorkflow.getEmptyDatasets());
+
+        System.out.println(sdmxVtlWorkflow.getTransformationsVTL());
+
+        // Invalid step definition for:CHECK_MUNICIPALITY
+        // - Caused by: fr.insee.vtl.engine.exceptions.UndefinedVariableException: undefined variable UNIQUE_MUNICIPALITY
+        engine.getBindings(ScriptContext.ENGINE_SCOPE).putAll(sdmxVtlWorkflow.getEmptyDatasets());
+        Map<String, PersistentDataset> result = sdmxVtlWorkflow.run();
+        assertThat(result).containsKeys(
+                "BPE_CENSUS_NUTS3_2021", "BPE_MUNICIPALITY", "BPE_NUTS3"
+        );
+    }
+
     @Test
     void testGetEmptyDataset() {
 

diff --git a/vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml b/vtl-sdmx/src/test/resources/DSD_BPE_CENSUS.xml
@@ -371,6 +371,7 @@
         <str:TransformationSchemes>
           <str:TransformationScheme agencyID="FR1" id="BPE_CENSUS" version="1.0" vtlVersion="2.0">
             <com:Name xml:lang="en">Transformation Scheme for BPE - CENSUS</com:Name>
+            <str:RulesetScheme>urn:sdmx:org.sdmx.infomodel.transformation.RulesetScheme=FR1:RS1(1.0)</str:RulesetScheme>
             <str:Transformation id="STEP_1" isPersistent="false">
               <com:Name xml:lang="en">Step 1</com:Name>
               <com:Description xml:lang="en">Validation of municipality code in input file</com:Description>