Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor : Optimisation rerendu #358

Open
wants to merge 1 commit into
base: v3-master
Choose a base branch
from
Open

Refactor : Optimisation rerendu #358

wants to merge 1 commit into from

Conversation

Grafikart
Copy link
Collaborator

Il faut à tout prix éviter les changements d'état inutils dans les useEffect (en général un setXxx() dans un useEffect() est un signe de problème). useMemo() convient en général mieux à la situation.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

renaud23
renaud23 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@renaud23 renaud23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui toujours un rendu de moins, c'est mieux.

Base automatically changed from v3-develop to v3-master December 18, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaud23 renaud23 renaud23 approved these changes

@laurentC35 laurentC35 Awaiting requested review from laurentC35

Assignees
No one assigned
Labels
easy-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Grafikart @renaud23