Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the drag and drop filter handling specification #514

Open
romaintailhurat opened this issue Nov 24, 2021 · 1 comment
Open

Review the drag and drop filter handling specification #514

romaintailhurat opened this issue Nov 24, 2021 · 1 comment
Assignees
Labels
Area: Refonte P3 ticket pour le refonte Pogues

Comments

@romaintailhurat
Copy link
Collaborator

When a component is moved via drag and drop in the questionnaire view, the specification for handling filters is the following:

a. if the component is not a member of any filter, do nothing
b. if the component is the first and last member, delete the filter
c. if the component is the first member, replace it by the next element sharing its type (anywhere in the questionnaire)
d.if the component is the last member, replace it by the preceding element sharing its type (anywhere in the questionnaire)

I falsely identified the case b. as a bug (see the archived issue).

Nonetheless, it appears quite brutal.

To smooth things a bit, we may propose an alternative behavior, vaguely outlined by:

  • let the filter in place, whatever the target location
  • if the filter is nonsensical (eg the condition question is inside the filter block), we may alert the designer, and tag the filter as deactivated (and thus we won't propagate it when sending the payload for generation)
@romaintailhurat
Copy link
Collaborator Author

I need to describe the integrity checks we want for filters.

@JulienCarmona JulienCarmona added the Type: Feature New feature for Bowie applications label Oct 11, 2024
@AnneHuSKa AnneHuSKa removed the Type: Feature New feature for Bowie applications label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Refonte P3 ticket pour le refonte Pogues
Projects
None yet
Development

No branches or pull requests

3 participants