Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/duplicate identifiers #159

Closed
wants to merge 10 commits into from
Closed

Fix/duplicate identifiers #159

wants to merge 10 commits into from

Conversation

nsenave
Copy link
Contributor

@nsenave nsenave commented Apr 25, 2023

Fix: duplicate technical identifiers in case of questionnaire composition

InseeFr/Pogues#660

Pogues UI allows to duplicate questionnaires. Thus, when referencing an external questionnaire, this can lead to duplicate of technical identifiers.

Content of this pull request

When doing questionnaire "de-referencing", for each object of a referenced questionnaire, prefix its id with the referencing questionnaire's id.

  • Refactor the de-referencing steps further to make it easier to maintain/extend.
  • Add unit test cases corresponding to this issue.
  • Implement prefixing of identifiers of referenced questionnaires.
  • Fix the integration test case under the folder previously named translation_issue.

@nsenave nsenave self-assigned this Apr 25, 2023
@ORogel
Copy link
Contributor

ORogel commented Jun 6, 2023

Je vais la recréer avec une develop à jour

@ORogel ORogel mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questionnaire composition - Handle objects with same technical ID
2 participants