New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meta env #713

Merged

laurentC35 merged 2 commits into develop from fix/meta-env

Oct 11, 2023

Collaborator

Grafikart commented Oct 9, 2023

Queen v2 uses webpack and having a variable based on meta.env creates an issue with building

WARNING in ./node_modules/@inseefr/lunatic/lib/utils/env.js 8:13-24
Critical dependency: Accessing import.meta directly is unsupported (only property access or destructuring is supported)

Originally I created the intermediary variable to make it work with TypeScript. This MR removes this intermediary variable to avoid issue with webpack.


          fix: meta env usage

c363c22

Grafikart changed the base branch from main to develop

October 9, 2023 08:10

Grafikart requested a review from QRuhier

October 9, 2023 08:11


          bump: version lunatic

91511d2

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

laurentC35 approved these changes

View reviewed changes

laurentC35 merged commit a37cc7d into develop

7 of 9 checks passed

laurentC35 deleted the fix/meta-env branch

October 30, 2023 09:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet