Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose verifyEmailCode and resendEmailCode through UploadManager and simplify arguments #118

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Dec 12, 2024

Automatically detect the app's language to avoid having to pass it to resendEmailCode and take this opportunity to also expose both verifyEmailCode and resendEmailCode through the UploadManager instead of accessing it directly through UploadRepository

@LunarX LunarX added the enhancement New feature or request label Dec 12, 2024
@LunarX LunarX requested review from sirambd and tevincent December 12, 2024 10:10
@LunarX LunarX self-assigned this Dec 12, 2024
@LunarX LunarX changed the title Take enum for language feat: Expose verifyEmailCode and resendEmailCode through UploadManager and simplify arguments Dec 12, 2024
@sirambd sirambd enabled auto-merge December 12, 2024 13:26
@LunarX LunarX force-pushed the take-enum-for-language branch from c9e1e63 to 550d5a8 Compare December 12, 2024 13:27
Copy link

sonarcloud bot commented Dec 12, 2024

@sirambd sirambd merged commit a100628 into main Dec 12, 2024
6 checks passed
@sirambd sirambd deleted the take-enum-for-language branch December 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants