fix: Fix the size of floating panel just for iPad #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/InfomaniakCoreSwiftUI/Modifiers/FloatingPanelHelper.swift
Outdated
Show resolved
Hide resolved
Matthieu-dgl
force-pushed
the
fix-floating-panel-on-ipad
branch
from
9946d54 to
4adfc1f
Compare
Matthieu-dgl
force-pushed
the
fix-floating-panel-on-ipad
branch
from
fe4552e to
f7401fa
Compare
|
I'm okay with the code. Waiting for a branch on mail to test it |
|
valentinperignon
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a new floatting panel with just a device check to make it an iPad, I don't know if it's the most optimised. I'm open to suggestions.