Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FileAccessError on a parent detection. #411

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

herve-er
Copy link
Contributor

@herve-er herve-er commented Nov 27, 2024

If an application (e.g., Microsoft Money) creates a locked file, the localfilesystemobserver will not be able to read its attributes and will call handleAccessDenied.

Since the item is not present in the snapshot, handleAccessDenied will assume that the permission issue originates from the parent directory and will therefore blacklist the parent.

The problem is that in this case, this assumption is incorrect; the issue does not come from the parent directory.

When the parent directory is later unblacklisted, most files within it will be synced again, often leading to pseudo-create conflicts.

However, if one of the files in the folder has been modified, it will be blacklisted because it is not a pseudo conflict but a genuine one. This scenario is highly likely, as demonstrated in this specific case: Microsoft Money systematically modifies a file in the folder after generating a locked temporary file.

@herve-er herve-er added this to the 3.6.8 milestone Nov 27, 2024
@herve-er herve-er self-assigned this Nov 27, 2024
@herve-er herve-er marked this pull request as ready for review November 28, 2024 08:44
@herve-er herve-er requested a review from a team as a code owner November 28, 2024 08:44
@herve-er herve-er marked this pull request as draft November 28, 2024 08:44
@herve-er herve-er marked this pull request as ready for review November 28, 2024 12:33
@herve-er herve-er requested a review from ClementKunz December 6, 2024 09:01
@ClementKunz ClementKunz enabled auto-merge December 6, 2024 10:12
Copy link

sonarcloud bot commented Dec 6, 2024

@ClementKunz ClementKunz merged commit 33c7d8e into develop Dec 6, 2024
7 checks passed
@ClementKunz ClementKunz deleted the KDESKTOP-1416-Remaining-blacklisted-issue branch December 6, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants