-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance FileAccessError on a parent detection. #411
Merged
ClementKunz
merged 10 commits into
develop
from
KDESKTOP-1416-Remaining-blacklisted-issue
Dec 6, 2024
Merged
Enhance FileAccessError on a parent detection. #411
ClementKunz
merged 10 commits into
develop
from
KDESKTOP-1416-Remaining-blacklisted-issue
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopheLarchier
previously approved these changes
Nov 29, 2024
ClementKunz
reviewed
Dec 5, 2024
ClementKunz
reviewed
Dec 5, 2024
ClementKunz
approved these changes
Dec 6, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an application (e.g., Microsoft Money) creates a locked file, the localfilesystemobserver will not be able to read its attributes and will call handleAccessDenied.
Since the item is not present in the snapshot, handleAccessDenied will assume that the permission issue originates from the parent directory and will therefore blacklist the parent.
The problem is that in this case, this assumption is incorrect; the issue does not come from the parent directory.
When the parent directory is later unblacklisted, most files within it will be synced again, often leading to pseudo-create conflicts.
However, if one of the files in the folder has been modified, it will be blacklisted because it is not a pseudo conflict but a genuine one. This scenario is highly likely, as demonstrated in this specific case: Microsoft Money systematically modifies a file in the folder after generating a locked temporary file.