-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kdesktop 1269 app doesn t start because of an unknown proxy type #355
Merged
ClementKunz
merged 28 commits into
develop
from
KDESKTOP-1269-App-doesn-t-start-because-of-an-unknown-proxy-type
Oct 30, 2024
Merged
Kdesktop 1269 app doesn t start because of an unknown proxy type #355
ClementKunz
merged 28 commits into
develop
from
KDESKTOP-1269-App-doesn-t-start-because-of-an-unknown-proxy-type
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f-an-unknown-proxy-type
…roxy-type' of github.com:Infomaniak/desktop-kDrive into KDESKTOP-1269-App-doesn-t-start-because-of-an-unknown-proxy-type
ClementKunz
reviewed
Oct 23, 2024
src/libsyncengine/update_detection/file_system_observer/remotefilesystemobserverworker.cpp
Outdated
Show resolved
Hide resolved
ClementKunz
reviewed
Oct 23, 2024
ClementKunz
reviewed
Oct 23, 2024
ClementKunz
reviewed
Oct 23, 2024
ClementKunz
reviewed
Oct 23, 2024
…f-an-unknown-proxy-type
ClementKunz
previously approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, including suggestions to avoid duplicated code caused by similar logging operations.
…roxy-type' of github.com:Infomaniak/desktop-kDrive into KDESKTOP-1269-App-doesn-t-start-because-of-an-unknown-proxy-type
…roxy-type' of github.com:Infomaniak/desktop-kDrive into KDESKTOP-1269-App-doesn-t-start-because-of-an-unknown-proxy-type
Quality Gate passedIssues Measures |
luc-guyot-infomaniak
approved these changes
Oct 30, 2024
ClementKunz
deleted the
KDESKTOP-1269-App-doesn-t-start-because-of-an-unknown-proxy-type
branch
October 30, 2024 10:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.