Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set min editor height #27

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Set min editor height #27

merged 2 commits into from
Jul 11, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Jul 10, 2024

If the editor only contains tags with not texts, it can become 0px high which renders it unclickable. This sets the min height to one ligne so there's always somewhere to click to take the focus. Also use this opportunity to change the section into a div to stay coherent with iOS and because a section is not required here

Depends on #26

@LunarX LunarX added bug Something isn't working enhancement New feature or request quick A pull request consisting of a few lines labels Jul 10, 2024
@LunarX LunarX self-assigned this Jul 10, 2024
Copy link

sonarcloud bot commented Jul 10, 2024

Base automatically changed from fix-editor-content-twitching to main July 11, 2024 13:48
Copy link

This PR/issue depends on:

@LunarX LunarX merged commit 8145427 into main Jul 11, 2024
9 checks passed
@LunarX LunarX deleted the set-min-editor-height branch July 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants