Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move saving of the html where it actually matters #25

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Jul 5, 2024

onSaveInstanceState is cool for when you want to survive process being killed but onDestroyView is enough to survive configuration changes

Depends on #24

@LunarX LunarX added the quick A pull request consisting of a few lines label Jul 5, 2024
@LunarX LunarX self-assigned this Jul 5, 2024
@LunarX LunarX requested a review from sirambd July 5, 2024 13:23
onSaveInstanceState is cool for when you want to survive process being killed but onDestroyView is enough to survive configuration changes
@LunarX LunarX force-pushed the fix-html-saving branch from b0e3953 to 962b5b4 Compare July 9, 2024 07:36
Copy link

sonarcloud bot commented Jul 9, 2024

Base automatically changed from support-parallele-html-export to main July 9, 2024 08:07
@github-actions github-actions bot removed the dependent label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

This PR/issue depends on:

@sirambd sirambd merged commit ee32dec into main Jul 9, 2024
5 checks passed
@sirambd sirambd deleted the fix-html-saving branch July 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants