-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically validate the email verification code (no need to press <ENTER>) #1582
Comments
@Grraahaam I can work on this issue if anyone else is not working currently |
I agree, we could improve the UX by letting it automatically continue after pasting the full code. @kavinda1995 Yes! That would be awesome! |
@DanielHougaard This change doesnt change the validation logic itself, so it's easy to implement and will already help. But I think that the verification link would be an even better idea in the long term (e.g. code already in the URL) as it'll make the verification step even faster and less prone to error for people who wrongly copy/pasted the code from the mail for example (e.g. missing digits or mail formatting issues), but the logic might need to be updated in this case. WDYT? |
@Grraahaam I agree, that would be even better. I wouldn't start doing that just yet though. We need to make the emails nicer in general at some point, and I think such a change would fall pretty nicely into that scope. For now I think making it automatically continue efter entering the code is the right move! |
Absolutely!
Actually I've started an email branding branch a while ago (#444), but didn't took time to migrate it to https://github.com/resendlabs/react-email |
Oh wow I didn't see that one, awesome! React email is great, and this is actually what I had in mind for the mail refactor. Currently it's not a huge priority, but it will defiantly become a more pressing topic in the future. |
Is this issue resolved? |
Hey @vishavsingla ! Doesnt seems to be.. @kavinda1995 was willing to work on it |
Is the issue resolved? |
I'll take this if it's available |
@Grraahaam I can work on this issue if issue is open |
@Grraahaam Can you please assign me this issue, if it is still open |
…ation code (no need to press <ENTER>)
@DanielHougaard Here is a pull request to solve this bug , #2977 . Hope this works |
@Grraahaam I would love to work on this issue if it is still open. |
Feature description
Today, when I create an account, I'm receiving the verification code to sign in by email. I then need to copy and paste it in the app, after what I need to press ENTER or the submit button.
What do you think?
Why would it be useful?
It'd improve the UX and simplify the user's verification process
Additional context
Related issues:
The text was updated successfully, but these errors were encountered: