Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-337] improve secret imports CRUD resource #1231

Closed
Pierre-Green opened this issue Dec 11, 2023 · 1 comment
Closed

[ENG-337] improve secret imports CRUD resource #1231

Pierre-Green opened this issue Dec 11, 2023 · 1 comment

Comments

@Pierre-Green
Copy link

Pierre-Green commented Dec 11, 2023

Feature Description

Currently, the POST, PUT, and DELETE endpoints for secret imports respond with a success message (HTTP CODE 200). The proposed enhancement involves having these endpoints return an object containing the secretImport field, similar to the behavior of the GET endpoint.

Why would it be useful?

Aligning the response format of these endpoints with other CRUD resources, such as secrets, which return objects instead of plain messages, would provide consistency. Additionally, this change is essential for implementing a comprehensive terraform resource for secret-imports.

Additional context

I've initiated a draft PR in the terraform provider repository to facilitate the management of secret imports, which can be found here: Terraform Provider Infisical PR #26.

From SyncLinear.com | ENG-337

@vmatsiiako vmatsiiako changed the title improve secret imports CRUD resource [ENG-337] improve secret imports CRUD resource Dec 11, 2023
@akhilmhdh
Copy link
Member

Closing as stale and fixed with new backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants