Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add swap data buildooor #50

Open
4 tasks
janndriessen opened this issue May 16, 2024 · 2 comments
Open
4 tasks

feat: add swap data buildooor #50

janndriessen opened this issue May 16, 2024 · 2 comments

Comments

@janndriessen
Copy link
Collaborator

janndriessen commented May 16, 2024

With the upcoming changes of getting rid of 0x dependencies it makes sense to make building swap data more sophisticated (and generic). This could be done by adding a specific builder class.

  • analyze current ways of creating swap data (hypothesis: too intertwined with 0x quotes)
  • create scenarios to test
  • create tests
  • write builder class
@janndriessen
Copy link
Collaborator Author

a buildooor could make sure to always have the input/output address in the path

@janndriessen
Copy link
Collaborator Author

could do a protocol to implement for a builder class that is then based on the actual service being used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant