[WIP] Process references #73
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good to me. How were you thinking of splitting the functions? The existing implementation looks pretty efficient but it would be nice to be able to add a processor by just adding a function (like it was before I threw a spanner in the works!)
Otherwise, I only have an administrative comment.
setup.py
Outdated
| @@ -17,7 +17,7 @@ | |||
| author="Research Computing Service, Imperial College London", | |||
| author_email="[email protected]", | |||
| url="https://github.com/ImperialCollegeLondon/R2T2", | |||
| install_requires=["wrapt"], | |||
| install_requires=["wrapt", "bibtexparser"], | |||
There was a problem hiding this comment.
Have we not moved to poetry? Should this not go in pyproject.toml?
There was a problem hiding this comment.
It should, but #67 needs to be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the processing of the references depending on their type (plain, doi and bibkey).
I'm working in changing the current implementation to separate functions and adding tests, but I wanted to leave this here as a WIP to get some feedback from you all, specially from @ChasNelson1990 who was working on using bibtex.