Openid4v #93
Closed
Openid4v #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse_types and not response_types_supported which may appear in client configuration.
…eturned. Cases where response_type was not a list but rather a space separated string. Added logging. As default value add an empty AuthBroker instead of a dictionary which does not support the same interface. Don't set class in code.
Added the client part of DPoPClientAuthn.
verify_response_type() didn't return False as it should. Better handling of default configuration. Refactored par.push_authorization such that I could access the method for testing. Return enough parameters in the PAR response to allow it to be used directly for the following authentication request. Fixed spelling error in service.Service.__init__(). Also made it clear that default methods are ONLY used if nothing is specified. Cleared up utils.get_state_parameter()
Added some logging.
…nse_types and not response_types_supported which may appear in client configuration.
…eturned. Cases where response_type was not a list but rather a space separated string. Added logging. As default value add an empty AuthBroker instead of a dictionary which does not support the same interface. Don't set class in code.
Added the client part of DPoPClientAuthn.
verify_response_type() didn't return False as it should. Better handling of default configuration. Refactored par.push_authorization such that I could access the method for testing. Return enough parameters in the PAR response to allow it to be used directly for the following authentication request. Fixed spelling error in service.Service.__init__(). Also made it clear that default methods are ONLY used if nothing is specified. Cleared up utils.get_state_parameter()
Added some logging.
… response_types and response_types_supported. The latter mostly/solely(?) in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are changes that came about as a consequence of work with the OpenID4V*.