Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple values for a key param #108

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

lionick
Copy link
Contributor

@lionick lionick commented Jul 8, 2024

We need to change the implementation of to_urlencoded to support the doseq option of the urllib.parse.urlencode function.

The documentation is here: https://docs.python.org/3/library/urllib.parse.html#urllib.parse.urlencode

@c00kiemon5ter
Copy link
Member

This is needed to construct URLs with multiple values of a query param.

Specifically, the Resource Indicators RFC allows specifying multiple target resources to be included as part of the aud claim for a generated token.

@rohe
Copy link
Contributor

rohe commented Aug 25, 2024

@lionick can you rebase this (and the other PRs you have) onto the present main ?

@lionick
Copy link
Contributor Author

lionick commented Sep 4, 2024

@rohe I have rebased it. When merged, I will rebase and the other.

@rohe rohe merged commit 313777e into IdentityPython:main Sep 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants