Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support subdomain matching pattern #25

Open
eldesh opened this issue Apr 15, 2020 · 0 comments
Open

Support subdomain matching pattern #25

eldesh opened this issue Apr 15, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@eldesh
Copy link
Contributor

eldesh commented Apr 15, 2020

Domain matching rule using regex seems to overkill.
Using regex, it is hard to predict what domain matches the rule.
More restricted pattern matching syntax is preferable like:

address:
  Specif:
    Domain:
      # match "mail.google.com", "images.google.com", ...
      # not match "google.com", "www.images.google.com"
      pattern: "*.google.com"
@eldesh eldesh added the enhancement New feature or request label Apr 15, 2020
@eldesh eldesh changed the title Subdomain matching Support subdomain matching pattern Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant