Use severity as as default sort #1121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
sort-by-severity-as-default
branch
from
3793318 to
9b37857
Compare
raviks789
reviewed
Jan 9, 2025
| @@ -50,15 +50,19 @@ public function indexAction() | |||
|
|
|||
| $limitControl = $this->createLimitControl(); | |||
| $paginationControl = $this->createPaginationControl($hosts); | |||
|
|
|||
| $defaultSort = 'host.state.severity desc,host.state.last_state_change desc'; | |||
There was a problem hiding this comment.
Suggested change
| $defaultSort = 'host.state.severity desc,host.state.last_state_change desc'; | |
| $defaultSort = ['host.state.severity DESC', 'host.state.last_state_change DESC']; |
This looks more readable to me.
Comment on lines
58
to
59
| 'host.display_name' => t('Name'), | ||
| 'host.state.severity desc,host.state.last_state_change desc' => t('Severity'), |
There was a problem hiding this comment.
Suggested change
| 'host.display_name' => t('Name'), | |
| 'host.state.severity desc,host.state.last_state_change desc' => t('Severity'), | |
| 'host.state.severity desc,host.state.last_state_change desc' => t('Severity'), | |
| 'host.display_name' => t('Name'), |
You need to also change the order of this array to reflect that the hosts were ordered by severity by default.
| @@ -60,6 +60,8 @@ public function indexAction() | |||
|
|
|||
| $limitControl = $this->createLimitControl(); | |||
| $paginationControl = $this->createPaginationControl($services); | |||
|
|
|||
| $defaultSort = 'service.state.severity desc,service.state.last_state_change desc'; | |||
There was a problem hiding this comment.
Suggested change
| $defaultSort = 'service.state.severity desc,service.state.last_state_change desc'; | |
| $defaultSort = ['service.state.severity DESC', 'service.state.last_state_change Desc']; |
| @@ -60,6 +60,8 @@ public function indexAction() | |||
|
|
|||
| $limitControl = $this->createLimitControl(); | |||
| $paginationControl = $this->createPaginationControl($services); | |||
|
|
|||
| $defaultSort = 'service.state.severity desc,service.state.last_state_change desc'; | |||
| $sortControl = $this->createSortControl( | |||
| $services, | |||
| [ | |||
There was a problem hiding this comment.
Same here, change the order of the array to reflect the default sort.
sukhwinder33445
force-pushed
the
sort-by-severity-as-default
branch
from
9b37857 to
deea667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1096