Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: ✨ Is1779/search users #6966

Draft
wants to merge 114 commits into
base: master
Choose a base branch
from

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Dec 13, 2024

What do these changes do?

ReDoc

  • Implement search users by partial username and email (if privacy settings allow).
  • Implements get user by user_id
  • Moved former /users to /admin/users since it was used for admin purposes

Related issue/s

How to test

  • Acceptance test defined in test_get_and_search_public_users

Dev-ops checklist

@pcrespov pcrespov self-assigned this Dec 13, 2024
@pcrespov pcrespov added this to the Event Horizon milestone Dec 13, 2024
@pcrespov pcrespov added a:webserver issue related to the webserver service a:api framework api, data schemas, a:models-library labels Dec 13, 2024
Copy link

sonarcloud bot commented Dec 13, 2024

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 70.73171% with 192 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (4eeaa5c) to head (6d27a71).

❗ There is a different number of reports uploaded between BASE (4eeaa5c) and HEAD (6d27a71). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (4eeaa5c) HEAD (6d27a71)
unittests 30 28
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6966      +/-   ##
==========================================
- Coverage   88.10%   81.23%   -6.87%     
==========================================
  Files        1592     1616      +24     
  Lines       62326    63319     +993     
  Branches     2012     2069      +57     
==========================================
- Hits        54912    51437    -3475     
- Misses       7078    11535    +4457     
- Partials      336      347      +11     
Flag Coverage Δ
integrationtests 64.66% <57.87%> (-0.33%) ⬇️
unittests 78.71% <63.87%> (-7.62%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.49% <ø> (ø)
pkg_dask_task_models_library 97.09% <ø> (ø)
pkg_models_library 91.37% <91.17%> (+0.13%) ⬆️
pkg_notifications_library 84.57% <ø> (ø)
pkg_postgres_database 88.26% <100.00%> (+0.20%) ⬆️
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 74.58% <ø> (ø)
pkg_settings_library 90.60% <ø> (ø)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 97.00% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 95.42% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (ø)
director_v2 91.40% <ø> (ø)
dynamic_scheduler 96.99% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.38% <ø> (-0.27%) ⬇️
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 65.60% <59.02%> (-22.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eeaa5c...6d27a71. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:api framework api, data schemas, a:models-library a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant