Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Adding dynamic services monitoring dashboard (⚠️devops) #6784

Merged
merged 149 commits into from
Dec 4, 2024
Merged

✨Adding dynamic services monitoring dashboard (⚠️devops) #6784

merged 149 commits into from
Dec 4, 2024

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 21, 2024 •
edited
Loading

⚠️ devops

What do these changes do?

After adding the dynamic-scheduler there is no easy way to view what is happening to the dynamic services .
This live dashboard helps with monitoring the status of services (legacy + new style) and figuring out what went wrong with them.

Actions for maintainers:

  • stopping the services (same as when the user presses STOP form the oSPARC UI)
  • and removing from tracking (in case of bugs it is necessary to remove the item from tracking, this allows to easily do so)

Changes:

  • ✨ dashboard exposed on http://127.0.0.1.nip.io:8012
  • ♻️ moved health dynamic-scheduler's endpoint form / to /health

Preview

Starting service from oSPARC

start_stop_services

Stopping service from dynamic-scheduler monitoring dashboard

stop_service_from_tracker

Show internal details as tracked by the dynamic-scheduler

information_about_service

Related issue/s

How to test

Dev-ops checklist

giancarloromeo and others added 30 commits September 18, 2024 11:45
@giancarloromeo @GitHK
⬆️ Upgrade models-library (pydantic v2) (ITISFoundation#6333)
d2d81c0 
Co-authored-by: Andrei Neagu <[email protected]>
@giancarloromeo
♻️ Add common library (ITISFoundation#6495)
19e3923
@giancarloromeo
⬆️ Upgrade libraries (pydantic v2) (ITISFoundation#6366)
1d92881
@giancarloromeo
Upgrade agent service (Pydantic v2) (ITISFoundation#6508)
329b00d
@giancarloromeo
Upgrade EFS guardian service (Pydantic v2) (ITISFoundation#6516)
6786b92
@giancarloromeo
Upgrade invitations service (Pydantic v2) (ITISFoundation#6513)
bbe92a2
@giancarloromeo
Upgrade clusters keeper service (Pydantic v2) (ITISFoundation#6519)
42c0a68
@sanderegg
Merge remote-tracking branch 'origin/master' into pydantic_v2_migrati…
1c833e0 
…on_do_not_squash_updates
@sanderegg
♻️Pydantic V2 upgrade: autoscaling (ITISFoundation#6535)
cac8134
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for dynamic-sidecar (ITISFoun…
e97258e 
…dation#6534)

Co-authored-by: Andrei Neagu <[email protected]>
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for dynamic-scheduler (ITISFo…
463488b 
…undation#6547)

Co-authored-by: Andrei Neagu <[email protected]>
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for agent (ITISFoundation#6546)
c2b4983 
Co-authored-by: Andrei Neagu <[email protected]>
@GitHK @sanderegg
🎨 pydantic2 migration: fixed unit-tests for payments (ITISFoundation#…
64293f0 
…6553)

Co-authored-by: Andrei Neagu <[email protected]>
@giancarloromeo @sanderegg
Upgrade resource usage tracker (Pydantic v2) (ITISFoundation#6517)
cf5546b
@sanderegg
Merge remote-tracking branch 'origin/master' into pydantic_v2_migrati…
3b188f5 
…on_do_not_squash_updates
@sanderegg
Merge remote-tracking branch 'origin/master' into pydantic_v2_migrati…
4716e55 
…on_do_not_squash_updates
@sanderegg
missing file from re-creating branch
84f1e51
@sanderegg
restored from old pydanitc_v2_migration branch
cf95d81
@sanderegg
fixes after merge
7be9541
@sanderegg
⬆️Dask sidecar: migration to v2 (ITISFoundation#6591)
6199ed6
@sanderegg
♻️Use correct import (ITISFoundation#6597)
cd6f545
@sanderegg
⬆️Datcore adapter: migration (ITISFoundation#6594)
3cf68ba
@sanderegg
Merge remote-tracking branch 'upstream/master' into update-branch
fb48eb1
@sanderegg
Merge pull request ITISFoundation#6600 from sanderegg/update-branch
82c69d0 
🎨Update from upstream/master
@sanderegg
⬆️Migration: Storage (ITISFoundation#6599)
7410516
@giancarloromeo
⬆️ Upgrade API Server service (Pydantic v2) (ITISFoundation#6580)
39aed6a
@sanderegg
♻️Fix settings library tests (ITISFoundation#6605)
e38cf4e
@sanderegg
Merge remote-tracking branch 'upstream/master' into update-branch2
00f8674
@sanderegg
Merge pull request ITISFoundation#6609 from sanderegg/update-branch2
06df37d 
⬆️Update from upstream (must be merged-commited)
@sanderegg
Merge remote-tracking branch 'upstream/master' into upgrade-master-3
3195f1e
bisgaard-itis
bisgaard-itis approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks a lot for the effort. I agree that we should have the same path to the health check everywhere.

YuryHrytsuk
YuryHrytsuk approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

I would be nice to automate (maybe not 100%) this logic in the future so that this dashboard is not needed 👌

matusdrobuliak66
matusdrobuliak66 reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@YuryHrytsuk
Copy link
Contributor

@GitHK let's me know when this is merged. I will merge respective PRs in OPS repos

@GitHK GitHK enabled auto-merge (squash) December 4, 2024 07:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK added the t:maintenance Some planned maintenance work label Dec 4, 2024
@GitHK GitHK merged commit 81c8ea0 into ITISFoundation:master Dec 4, 2024
89 checks passed
@GitHK GitHK deleted the pr-osparc-add-dybamic-services-monitor-dashboard2 branch December 4, 2024 08:03
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Dec 10, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@odeimaiz odeimaiz odeimaiz left review comments

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov pcrespov approved these changes

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

@mguidon mguidon Awaiting requested review from mguidon

Assignees

@GitHK GitHK

Labels
a:dynamic-scheduler t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
8 participants
@GitHK @YuryHrytsuk @pcrespov @odeimaiz @sanderegg @matusdrobuliak66 @bisgaard-itis @giancarloromeo