-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Director-v2: refactor computational scheduler #6652
♻️Director-v2: refactor computational scheduler #6652
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6652 +/- ##
==========================================
- Coverage 87.95% 87.86% -0.09%
==========================================
Files 1564 1220 -344
Lines 62899 53135 -9764
Branches 2088 962 -1126
==========================================
- Hits 55321 46689 -8632
+ Misses 7260 6269 -991
+ Partials 318 177 -141
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly some thoughts inspired in your changes
Thx
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/__init__.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_task.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_task.py
Show resolved
Hide resolved
services/director-v2/src/simcore_service_director_v2/modules/comp_scheduler/_task.py
Show resolved
Hide resolved
5840358
to
cbbe6b5
Compare
cbbe6b5
to
58db47b
Compare
Quality Gate passedIssues Measures |
What do these changes do?
make use of service-library background tasks facilities in computational scheduler
renamed modules
reverted tools in director-v0 to make it starteable again.
no change in functionality
Related issue/s
How to test
Dev-ops checklist