Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️Director-v2: refactor computational scheduler #6652

Merged
merged 23 commits into from
Nov 5, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 1, 2024

What do these changes do?

  • make use of service-library background tasks facilities in computational scheduler

  • renamed modules

  • reverted tools in director-v0 to make it starteable again.

no change in functionality

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Nov 1, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 1, 2024
@sanderegg sanderegg self-assigned this Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (dac26e1) to head (58db47b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6652      +/-   ##
==========================================
- Coverage   87.95%   87.86%   -0.09%     
==========================================
  Files        1564     1220     -344     
  Lines       62899    53135    -9764     
  Branches     2088      962    -1126     
==========================================
- Hits        55321    46689    -8632     
+ Misses       7260     6269     -991     
+ Partials      318      177     -141     
Flag Coverage Δ
integrationtests 64.84% <100.00%> (-0.02%) ⬇️
unittests 85.46% <100.00%> (-0.45%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 76.75% <100.00%> (+0.03%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.26% <ø> (ø)
catalog 89.52% <ø> (ø)
clusters_keeper 98.85% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (ø)
director_v2 90.81% <100.00%> (-0.04%) ⬇️
dynamic_scheduler 96.72% <ø> (ø)
dynamic_sidecar 89.72% <ø> (ø)
efs_guardian 90.00% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.15% <ø> (ø)
payments 93.09% <ø> (ø)
resource_usage_tracker 90.75% <ø> (+0.15%) ⬆️
storage 89.75% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.30% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac26e1...58db47b. Read the comment docs.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some thoughts inspired in your changes
Thx

@sanderegg sanderegg force-pushed the refactor-comp-scheduler branch 2 times, most recently from 5840358 to cbbe6b5 Compare November 4, 2024 17:28
@sanderegg sanderegg force-pushed the refactor-comp-scheduler branch from cbbe6b5 to 58db47b Compare November 4, 2024 17:38
Copy link

sonarcloud bot commented Nov 4, 2024

@sanderegg sanderegg merged commit cba3237 into ITISFoundation:master Nov 5, 2024
89 checks passed
@sanderegg sanderegg deleted the refactor-comp-scheduler branch November 5, 2024 07:00
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants