Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 pydantic v2 fixed broken unit tests #6649

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Nov 1, 2024

What do these changes do?

  • fixed issues with urllib3 incompatible versions
  • fixed dynamic-scheduler broken tests
  • fixed dynamic-sidecar broken tests

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.33%. Comparing base (8402270) to head (371cc6d).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           pydantic_v2_migration_do_not_squash_updates    #6649      +/-   ##
===============================================================================
+ Coverage                                        68.89%   70.33%   +1.44%     
===============================================================================
  Files                                              961      709     -252     
  Lines                                            42544    32932    -9612     
  Branches                                          1300      258    -1042     
===============================================================================
- Hits                                             29309    23163    -6146     
+ Misses                                           13011     9709    -3302     
+ Partials                                           224       60     -164     
Flag Coverage Δ *Carryforward flag
integrationtests 65.04% <ø> (ø) Carriedforward from 316af86
unittests 90.09% <100.00%> (+12.12%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.41% <ø> (ø)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter 93.17% <ø> (ø)
director ∅ <ø> (∅)
director_v2 76.21% <ø> (ø)
dynamic_scheduler 96.72% <100.00%> (∅)
dynamic_sidecar 89.27% <ø> (+29.62%) ⬆️
efs_guardian ∅ <ø> (∅)
invitations 93.49% <ø> (ø)
osparc_gateway_server 79.52% <ø> (ø)
payments ∅ <ø> (∅)
resource_usage_tracker 87.36% <ø> (ø)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 59.91% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8402270...371cc6d. Read the comment docs.

@GitHK GitHK changed the title Pr osparc pydantic v2 fixes 2 pydantic v2 fixes for my services Nov 5, 2024
@GitHK GitHK changed the title pydantic v2 fixes for my services pydantic v2 fixes Nov 5, 2024
@GitHK GitHK changed the title pydantic v2 fixes 🐛 pydantic v2 fixes to unit tests Nov 5, 2024
@GitHK GitHK changed the title 🐛 pydantic v2 fixes to unit tests 🐛 pydantic v2 fixed broken unit tests Nov 5, 2024
@GitHK GitHK marked this pull request as ready for review November 5, 2024 15:18
@GitHK GitHK requested a review from giancarloromeo November 5, 2024 15:18
…quash_updates' into pr-osparc-pydantic-v2-fixes-2
Copy link

sonarcloud bot commented Nov 6, 2024

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@GitHK GitHK merged commit 0527b1e into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 6, 2024
60 of 87 checks passed
@GitHK GitHK deleted the pr-osparc-pydantic-v2-fixes-2 branch November 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants