Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [Frontend] Fix: Selected Pricing Unit bgColor #6646

Merged
merged 5 commits into from
Nov 1, 2024
Merged

🐛 [Frontend] Fix: Selected Pricing Unit bgColor #6646

merged 5 commits into from
Nov 1, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 1, 2024 •
edited
Loading

What do these changes do?

reported by @matusdrobuliak66 @mguidon

The selection (what the user clicked) was properly transmitted to the backend, but its background color wasn't updated.

Bonus:

  • Do not allow changing selection in the list of units in the service description card

Bug:
Bug

Fix:
Fixed

Related issue/s

closes #6643

How to test

Dev-ops checklist

@odeimaiz odeimaiz self-assigned this Nov 1, 2024
@odeimaiz odeimaiz added bug buggy, it does not work as expected a:frontend issue affecting the front-end (area group) labels Nov 1, 2024
@odeimaiz odeimaiz added this to the Event Horizon milestone Nov 1, 2024
mguidon
mguidon approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS

@odeimaiz odeimaiz enabled auto-merge (squash) November 1, 2024 08:41
matusdrobuliak66
matusdrobuliak66 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

pcrespov
pcrespov reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

sanderegg
sanderegg reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mrnicegyu11 mrnicegyu11 disabled auto-merge November 1, 2024 09:47
@odeimaiz odeimaiz enabled auto-merge (squash) November 1, 2024 09:47
@mrnicegyu11 mrnicegyu11 merged commit 0bc2185 into ITISFoundation:master Nov 1, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Nov 6, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg left review comments

@pcrespov pcrespov pcrespov left review comments

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@mguidon mguidon mguidon approved these changes

@GitHK GitHK GitHK approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@ignapas ignapas Awaiting requested review from ignapas ignapas is a code owner

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) bug buggy, it does not work as expected
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.

Tiers are not selectable from the dashboard
7 participants
@odeimaiz @GitHK @pcrespov @mguidon @sanderegg @matusdrobuliak66 @mrnicegyu11