-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Enhanced groups/organizations web-api specs and validation 🚨 #6640
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6640 +/- ##
==========================================
- Coverage 87.93% 87.80% -0.14%
==========================================
Files 1564 1405 -159
Lines 62950 59373 -3577
Branches 2104 1599 -505
==========================================
- Hits 55358 52135 -3223
+ Misses 7267 6979 -288
+ Partials 325 259 -66
Continue to review full report in Codecov by Sentry.
|
df4cfb5
to
6463267
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks a lot for the effort
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good cleared in person
155a8cf
to
46434d9
Compare
46434d9
to
3612afd
Compare
Quality Gate passedIssues Measures |
What do these changes do?
During a debugging session with @odeimaiz, we observed that the Swagger site was displaying an incorrect interface for the
/groups
endpoints. The web API lacked properly defined OpenAPI Specifications (OAS) since this plugin hadn’t yet been updated to use Pydantic models.This PR addresses the problem by updating the OAS generator code and models in
api/webserver
, ensuring the new OAS correctly represent the interface and is better documented. Additionally, it now introduces input validation in thehandler
functions through these models, which wasn’t in place before. For now, output validation is enabled only in debug mode.We also manually verified all client calls to this resource in order to ensure compatibility with the frontend.
Related issue/s
How to test
GET /me
andGET /group/***
(with @odeimaiz )Dev-ops
None