Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨Redis: add optional Redis username #6381

Merged
merged 5 commits into from
Sep 17, 2024
Merged

🎨Redis: add optional Redis username #6381

merged 5 commits into from
Sep 17, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Sep 17, 2024 •
edited by YuryHrytsuk
Loading

What do these changes do?

This PR is from @YuryHrytsuk

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:infra+ops maintenance of infrastructure or operations (discussed in retro) label Sep 17, 2024
@sanderegg sanderegg added this to the Doppelbock milestone Sep 17, 2024
@sanderegg sanderegg self-assigned this Sep 17, 2024
@sanderegg sanderegg assigned YuryHrytsuk and unassigned sanderegg Sep 17, 2024
@YuryHrytsuk YuryHrytsuk enabled auto-merge (squash) September 17, 2024 13:33
YuryHrytsuk
YuryHrytsuk reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@YuryHrytsuk YuryHrytsuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added REDIS_USER to .env-devel

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.2%. Comparing base (cafbf96) to head (cfece4f).
Report is 552 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6381      +/-   ##
=========================================
+ Coverage    84.5%   88.2%    +3.6%     
=========================================
  Files          10    1500    +1490     
  Lines         214   62242   +62028     
  Branches       25    2070    +2045     
=========================================
+ Hits          181   54917   +54736     
- Misses         23    7004    +6981     
- Partials       10     321     +311
Flag Coverage Δ
integrationtests 64.6% <ø> (?)
unittests 86.2% <ø> (+1.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1449 files with indirect coverage changes

@YuryHrytsuk YuryHrytsuk self-requested a review September 17, 2024 14:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@YuryHrytsuk YuryHrytsuk merged commit 4ed5831 into ITISFoundation:master Sep 17, 2024
61 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Sep 18, 2024
Closed
29 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Oct 30, 2024
Closed
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
a:infra+ops maintenance of infrastructure or operations (discussed in retro)
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderegg @mrnicegyu11 @YuryHrytsuk