Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major upgrade to pydantic 2.0 #4481

Closed
22 tasks done
pcrespov opened this issue Jul 10, 2023 · 5 comments · Fixed by #6366, #6333, #6517 or #6578
Closed
22 tasks done

Major upgrade to pydantic 2.0 #4481

pcrespov opened this issue Jul 10, 2023 · 5 comments · Fixed by #6366, #6333, #6517 or #6578
Assignees
Labels
t:maintenance Some planned maintenance work
Milestone

Comments

@pcrespov
Copy link
Member

pcrespov commented Jul 10, 2023

💀 💀 💀 Never ever squash commits when updating from master branch 💀 💀 💀

Instructions

  1. update requirements make touch update reqs=pydantic
  2. install bump-pydantic uv pip install bump-pydantic
  3. bump-pydantic my_package
  4. fix what it did and fix all tests
  5. check warnings in the test and finish fixing
  6. create a PR and ask for review
  7. this PR shall be squash commited

Planned changes

Major upgrade not out-of-the box and requires some coordination. This upgrade will bring substantial speedup to the code. It would be desirable to measure the improvement. Should we setup some type of benchmark?

Both libraries have been releases so I added a constraint in requirements/constraints.txt

We should start testing first the upgrade with the packages and then when we understand the migration mechanisms we can do the rest of the repository.

Tasks

This is a sub issue from ITISFoundation/osparc-issues#675

MartinKippenberger

  1. a:webserver t:maintenance
    giancarloromeo
  2. a:director-v2 t:maintenance
    giancarloromeo
  3. a:apiserver t:maintenance
    giancarloromeo
  4. t:maintenance
    giancarloromeo
  5. a:dask-service
    sanderegg
  6. a:resource-usage-tracker t:maintenance
    giancarloromeo
  7. t:maintenance
    giancarloromeo
  8. t:maintenance
    giancarloromeo
  9. t:maintenance
    giancarloromeo
  10. t:maintenance
    giancarloromeo
  11. a:dynamic-scheduler t:maintenance
    GitHK
  12. a:dynamic-sidecar
    GitHK
  13. a:autoscaling
    sanderegg
  14. t:maintenance
    giancarloromeo
  15. t:maintenance
    giancarloromeo
  16. a:datcore-adapter
    sanderegg
  17. t:maintenance
    pcrespov
  18. t:maintenance
    pcrespov
  19. pcrespov
@sanderegg
Copy link
Member

@pcrespov explore the migration path

@sanderegg
Copy link
Member

sanderegg commented Oct 22, 2024

@pcrespov
packages/models-library/src/models_library/projects.py
image

@sanderegg
Copy link
Member

sanderegg commented Oct 22, 2024

@GitHK this looks worrisome (the last ruff comment), I think the task will not run
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/outputs/_manager.py
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment