Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocking of the COE process disables closing of the process, failing silently #134

Open
Unsongheroes opened this issue Feb 26, 2021 · 3 comments
Milestone

Comments

@Unsongheroes
Copy link
Contributor

No description provided.

@Unsongheroes Unsongheroes added this to the 9.9.9 milestone Feb 26, 2021
@Unsongheroes Unsongheroes self-assigned this Feb 26, 2021
@Unsongheroes
Copy link
Contributor Author

Unsongheroes commented Mar 19, 2021

GetPId() and isrunning() in the COEProcess file is causing issues if the pid file is being removed or auto-generated by the OS, a check is needed and a deletion of the pid file might be a good solution.

@idhugoid
Copy link
Contributor

When the pid file exists, but the COE is not responding (or was shutdown externally), the IsRunning() function succeeds when clicking on the Launch COE button in here

IsRunning() needs to go beyond asserting that the pid file works:

  • It may check if the pid process is still running (not perfect if it is not responsive)
  • It may check if the /version pinging of the server is good (this should always be tested...)

We should also try to delete the pid file in case we discover the server is not responding and but the file exists... Maybe issue a console error???

@maxs-rose maxs-rose assigned maxs-rose and unassigned maxs-rose Mar 25, 2021
@Unsongheroes
Copy link
Contributor Author

Things to try:

To block all TCP and UDP port except some port 80,443,8443 by windows defender firewall inbound and outbound rule, you could follow the steps:

  1. Control panel > System and Security > Windows Firewall > Advanced settings

  2. Right-click Inbound Rules and click new rule.

  3. Choose Port and next.

  4. Choose TCP and UDP, type 80,443,8443 in Specific local ports, and next.

  5. Choose Block the connection and next.

  6. Choose the profile you want to apply and next.

  7. Type the name and Description you want and finish.

I think instead of doing what it says here, you can go to the same place and the rule would just block a specific port

Than you can see if you can replicate or catch an error message...

@Unsongheroes Unsongheroes removed their assignment Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants