Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Config class #39

Open
davidrpugh opened this issue May 27, 2017 · 3 comments
Open

Refactor the Config class #39

davidrpugh opened this issue May 27, 2017 · 3 comments

Comments

@davidrpugh
Copy link
Member

davidrpugh commented May 27, 2017

@adrian-carro I would recommend using a config library rather than re-inventing the wheel with the current Config class. I have used HOCON in my previous Java/Scala work and it seems solid.

Once I finish PR #38, I will open a PR that swaps out the current Config class for one that uses the HOCON configuration library instead.

@adrian-carro
Copy link
Member

Oh, that library looks great! The main reason I didn't go for JSON was the absence of comments. I didn't know about this HOCON which, I assume, is a JSON superset with comments and other stuff, right?

@davidrpugh
Copy link
Member Author

@adrian-carro Correct. Here is a link to the Akka reference config for an example of what the config file would look like.

@rht
Copy link

rht commented Mar 24, 2020

In my python port of housing-model, I simplified the config by putting everything into a python class (https://github.com/rht/housing-model/blob/master/src/main/java/housing/Config.py). This way, no more parsing of a custom config file format is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants