Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.iets3.core.expr.typetags.units.quantity: QuantityReference and UnitReference Scope implementation not consistent #967

Open
arimer opened this issue Jun 6, 2024 · 1 comment
Labels
MPS 2022.2 Target MPS version of the issue wontfix

Comments

@arimer
Copy link
Member

arimer commented Jun 6, 2024

The way how Quantities and Units should be referenced is not consistent at the moment.

  • For QuantityReference there is currently no scope impl. at all. Meaning we rely on the model scope
  • For UnitReference a scoping is provided. It enforces that the "context node" where there reference is defined must implement IVisibleElementProvider

I think both should share a common logic, otherwise you end up in a situation, where you mind see Quantities of a Library_A but not the units which might be re-exported by Library_A.

@arimer arimer added MPS 2022.2 Target MPS version of the issue feedback needed wontfix and removed feedback needed labels Jun 6, 2024
@alexanderpann
Copy link
Member

Can we close the ticket if we don't indent to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MPS 2022.2 Target MPS version of the issue wontfix
Projects
None yet
Development

No branches or pull requests

2 participants