Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure running make cross_verify in oqs-gnutls #64

Closed
baentsch opened this issue Aug 7, 2023 · 3 comments · Fixed by #66
Closed

Failure running make cross_verify in oqs-gnutls #64

baentsch opened this issue Aug 7, 2023 · 3 comments · Fixed by #66

Comments

@baentsch
Copy link
Collaborator

baentsch commented Aug 7, 2023

When running this command, this happened:

s$ make cross_verify

[ gnutls ] Checking Requirements (Verify):
[ gnutls ] Done (Ok)
/bin/sh: 3: Syntax error: ";" unexpected
Makefile:110: recipe for target 'cross_verify' failed
make: *** [cross_verify] Error 2

Looking at the code the logic seems to be incorrect in that it simply runs each project's own "verify" but not on another project's artifacts (?)

Lastly, this code does not seem to generate the report CSV files. Are you still active on this @ueno ?

@ueno
Copy link
Contributor

ueno commented Aug 7, 2023

@baentsch yes, let me take a look.

@baentsch
Copy link
Collaborator Author

baentsch commented Aug 7, 2023

@baentsch yes, let me take a look.

Thanks very much! See #65 for a general OQS (also data) update (should you want to use this for your testing).

@ueno
Copy link
Contributor

ueno commented Aug 7, 2023

#66 should fix the shell syntax error; the same issue also happens with other providers (carl-redhound, corey-digicert, entrust, and kris) in the current master branch.

As for the actual cross verification logic, I'll check separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants