CMS artifacts need to be updated to use the standard algoritms

[johngray-dev]

Currently the CMS artifacts are using the IPD version of the algorithms, they should be updated to use the standard algorithm version.

[carl-wallace]

And when doing so bump the zip file version to 2On Nov 2, 2024, at 10:27 AM, John Gray ***@***.***> wrote: Currently the CMS artifacts are using the IPD version of the algorithms, they should be updated to use the standard algorithm version. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[codespree]

@dghgit @carl-wallace if you plan to update CMS artifacts, could you help me verify mine?

cms_initial_test_artifacts.zip

Also, if you could post yours here, I could try to verify yours.

[dghgit]

I get the string "IETF Hackathon" so I think they're working for me.

One issue I ran into is the private key encoding is missing the wrapping octet string - the contents of the privateKey field should be an encoding of an OCTET STRING, I've just noticed https://datatracker.ietf.org/doc/draft-ietf-lamps-cms-kyber/ is missing that, but I think it's an error, the wrapping OCTET STRING has always been included in the past for private keys, including with Edwards Curves, and dropping it at this point is going to make it extremely difficult to use a CHOICE in place of the OCTET STRING.

I've emailed Mike to mention the issue in the draft.

[codespree]

@dghgit I added a test case using the vectors in the draft:
codespree/quantcrypt@eb54459

As per the draft, I can use the public and private keys successfully.

Also, yesterday, I brought the implementation up to speed with draft-ietf-lamps-pq-composite-kem-05 via this commit:
codespree/quantcrypt@015415d

I am not entirely sure if my implementation uses the right triples. If you find any mistake let me know.

The triples are here:
https://github.com/codespree/quantcrypt/blob/f88195ed1e71c313069c8f2c311c98ea11255f77/src/cms/enveloped_data_builder.rs#L706

[carl-wallace]

@codespree I was able to decrypt the MLKEM768 and MLKEM1024 artifacts from your zip. I have not yet updated composite support (and may not get to that this week). Attached is an updated set of artifacts I just generated. If you could give these a try I'd appreciate it.
artifacts_cms_v2.zip

[dghgit]

Hi Carl, if the mystery text is "abc" I'd say these are a print!

[codespree]

@carl-wallace @ZPDSSAI has validated your artifacts. All's good.