Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio artifacts in TS channel with high(est) bitrate #1237

Closed
A-tG opened this issue Mar 29, 2023 · 3 comments · Fixed by #1240
Closed

Audio artifacts in TS channel with high(est) bitrate #1237

A-tG opened this issue Mar 29, 2023 · 3 comments · Fixed by #1240
Labels
Milestone

Comments

@A-tG
Copy link

A-tG commented Mar 29, 2023

Game and mods (from workshop) are latest versions at the moment. No ACE.
Teamspeak server version: 3.13.7 on Linux
client: 3.5.6
If ACRE's channel Audio codec is set to Opus Music with Quaility 10 for some clients sound is pitched down + crackling.
My input and output devices are all set to 24bit 48khz. I did not had any problems, but other client with 16 bit 44.1khz "Speakers" heard my voice with mentioned artifacts. No problems with Opus Voice Quality 10

I may add recorded example later.

@A-tG A-tG added the bug label Mar 29, 2023
@PabstMirror
Copy link
Collaborator

It may be caused because the plugin is getting a stereo mix and is expecting a mono.
(it's basically the same as pitch shifting by half)

fix in part of pr #1105

https://github.com/IDI-Systems/acre2/pull/1105/files#diff-5be897ee5ca93830134dd14c08605294f497f78b974eb3d85ed17063f5b2aeeaR50-R57

@A-tG
Copy link
Author

A-tG commented Mar 29, 2023

It sounds like that
acre-opus-music-codec-bug.zip
Quality does not matter, only type of codec

@jonpas
Copy link
Member

jonpas commented Apr 10, 2023

Quality does not matter, only type of codec

Yeah that makes sense. ACRE should be able to handle high bitrates (at least to level provided by TeamSpeak) without an issues, but different codecs, especially ones added later in TeamSpeak's life, may have issues as we are directly interacting with audio data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants