-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inline header or footer, via 'sticky' display group param #2564
base: master
Are you sure you want to change the base?
Conversation
…h inline sticky display group header
Visit the preview URL for this PR (updated for commit 14b3abb): https://plh-teens-app1--pr2564-feat-sticky-display-kdd0s6lh.web.app (expires Fri, 13 Dec 2024 16:34:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e4c0bab6b08dd290fbf002fd6e07987fa4b5fce1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out on the plh_kids_kw
deployment (with same theme selected) and found that some components don't disappear properly behind the sticky header.
PR Checklist
Description
Allows for inline template authoring of elements that stick to the top or bottom of the page.
This is achieved with a new param for the display group:
sticky
top
bottom
Also introduces a new parameter for the
title
component:variant: header
This feature can also be used to set the header/footer inside a nav-stack (#2550). See below for demo. This PR adds a new parameter for the
nav_stack: open
action, which should be used in this case (to hide the default nav-stack header):header: false
(defaulttrue
)false
to hide the default nav-stack header, e.g. when using an inline sticky header on the target template.Usage notes
Git Issues
Closes #
Screenshots/Videos
feat_display_group_sticky
sticky.dg.2.mov
Integration with nav-stacks:
Ssticky.w.nav.stack.mov