Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about the the equation 4 #72

Open
goldentimecoolk opened this issue Apr 10, 2024 · 0 comments
Open

A question about the the equation 4 #72

goldentimecoolk opened this issue Apr 10, 2024 · 0 comments

Comments

@goldentimecoolk
Copy link

Hi, in the equation 4 of the paper, there is a multiplication of MLP(C_q) and PE(x_q, y_q). But in the specific implementation, the query_pos (PE(x_q, y_q)) is directly input to the cross-attention and not multiplied by MLP(C_q). Instead, the pos_transformation is multiplied by MLP(C_q) two times, which seems to be inconsistent to the paper. Is there something wrong in my understanding?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant