always put the prep bof in the last room in the last session

[tpokorra]

to make it clear that it did not compete for votes

[tpokorra]

not so easy, because of roundsTable.last_location

BOF/src/classes/DBO.php

Line 868 in 809ff81

GROUP BY round_id) AS roundsTable

need to exclude the prep bof by workshop.id

[franc6]

I think I accounted for this properly already; if you look at BOF/src/classes/Results.php, there's a method to specifically set the Prep BoF, and the time slot and room are skipped because they're already "booked". I seem to recall that it was previously trying to put it always in a time slot by number (even if there were fewer or more time slots), and that I modified how it works before changing that.

[franc6]

See Results::bookPrepBoF(). It currently sets the prep bof to be in location id 1 of the last session. The unit tests also test this condition. Additionally, the prep bof is skipped by ID when it fills in everything else. Moving it to the last location in the last session should be trivial.

However, we just had a new situation arise for the Americas conference for this year, and I'm pretty sure for 2019, it was not desirable to have it in the last time slot. For 2021, attendance will be very low, so the prep team is moving the prep bof to its own time slot. To address these two issues, I'm thinking of making the following changes (which I can commit if everyone is happy with the idea, or do something better if someone has a better idea):

1. Add a new droplist option in the admin interface to let the admin specify in which time slot the prep bof should appear (defaults to explicit last time slot)
2. Add a new droplist option in the admin interface to let the admin specify in which room the prep bof should appear (defaults to explicit last room)
3. Add a new checkbox option in the admin interface to let the admin indicate if the prep bof should be in its own timeslot
4. If the option in 3 above is checked, then the prep bof won't actually be scheduled, on the assumption that if it's in its own time slot, it doesn't need to appear on the bof schedule. A warning will be displayed to the admin, and the other two new options will be disabled, too.

I'm suggesting the fourth change since that would make it easier to code, as it would be difficult to have any time slot not full.

[tpokorra]

sounds good to me!