Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmiciObjective: For sensi_orders>0, check that sensitivities wrt all relevant parameters are computed #1414

Open
dweindl opened this issue Jun 13, 2024 · 0 comments · May be fixed by #1416
Open
Assignees
Labels

Comments

@dweindl
Copy link
Member

dweindl commented Jun 13, 2024

Related to AMICI-dev/AMICI#2455

When we have an AmiciObjective and need to compute gradients, we should make sure that sensitivities can be computed w.r.t. all free parameters (this needs to be checked when constructing AmiciObjective, and whenever additional parameters are ixed). I.e. we need to check whether all non-fixed parameters exist in amici_model.getParameterIds(), taking into account AmiciObjective.parameter_mapping.

This is particularly important for PEtab import, where we aren't necessarily able to compute sensitivities w.r.t. to all parameters (AMICI-dev/AMICI#2456).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant