Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distill options passed into transformers #35

Closed
boneskull opened this issue Jul 30, 2019 · 1 comment
Closed

distill options passed into transformers #35

boneskull opened this issue Jul 30, 2019 · 1 comment
Assignees
Labels
chore Related to tests, packaging, build, releases, etc. package-transformers Involving transformers package

Comments

@boneskull
Copy link
Contributor

boneskull commented Jul 30, 2019

Currently, we're sending whole gobs of configuration to transformers when we don't need to. Each transformer should probably define the options that it expects (e.g. via a schema like Rules support), and we can use that to pick the various useful options.

Configuration can be passed via:

  1. Command-line flags (if supported)
  2. Top-level via RC file
  3. Command-specific via RC file
  4. Transform-specific via RC file

Furthermore, default options should cascade within a transformer chain. If an option defines e.g., fields, and the user has not, this setting should pass to the next transformer(s) in the chain as long as those transformers accept the configuration. The target transformer should prefer the config sent from the previous transformer and treat it like it was user-defined.

@boneskull boneskull added chore Related to tests, packaging, build, releases, etc. package-transformers Involving transformers package labels Jul 30, 2019
@boneskull boneskull self-assigned this Jul 30, 2019
@boneskull
Copy link
Contributor Author

duplicate of #78 imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to tests, packaging, build, releases, etc. package-transformers Involving transformers package
Projects
None yet
Development

No branches or pull requests

1 participant