Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On ISAM application_logs.clear and application_logs.delete, file_id parameter should be file_path instead #174

Open
kalemontes opened this issue Aug 13, 2019 · 1 comment

Comments

@kalemontes
Copy link

kalemontes commented Aug 13, 2019

Leaving the parameter name to file_id on application_logs.clear and application_logs.delete is misleading. This API call actually uses the file_path as the other /isam/application_logs functions.

For instance, when calling /isam/application_logs/get_all we will get the following response body :

{
	"contents": [
		{
			"path": "access_control/auditing",
			"name": "audit.log",
			"id": 0,
			"type": "File",
			"version": "1545058628",
			"file_size": 0
		}
	]
}

If you use the real file id, here it would be 0, when calling we usually get the following response "message": "The requested resource does not exist." while using the full file path, here it would be access_control/auditing/audit.log, it will do the expected job.

@ram-ibm
Copy link
Collaborator

ram-ibm commented Aug 14, 2019

The intention was to match the REST API documentation for the variables used in the function - so we did not have to document it again.

Looks like both clear() and delete() should simply take "files". Will look into updating it - problem is it may cause folks playbooks to break. Will need to think about how to maintain backward compatibility...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants