Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed line width in JAVA properties filter should be configurable. #146

Open
ducharmg opened this issue Jul 5, 2019 · 3 comments
Open

Comments

@ducharmg
Copy link

ducharmg commented Jul 5, 2019

The line width is fixed at 80. This is arbitrary and should be configurable.
Java Resource bundles have no such limitation.

private static final int COLMAX = 80;

@ducharmg
Copy link
Author

ducharmg commented Jul 8, 2019

another issue is the use of INDENT
private static final String INDENT = " ";

it adds extra spaces to the messages.

@srl295
Copy link
Contributor

srl295 commented Jul 17, 2019

What is the rationale for changing the line width? The files should be machine-parsed and not hand edited.

I think if anything, there could be no line width and no continuation characters used.

@ducharmg
Copy link
Author

I agree that neither line width or indent characters should be used.
But if we make them configurable, we can remove the continuation but still allow backwards compatibility with existing code.

I would suggest that line width = 0 be interpreted as no line length limit imposed and then the issue of the INDENT characters will be made moot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants