Skip to content

Commit

Permalink
Merge pull request #119 from IATI/fix/remove-logger-api
Browse files Browse the repository at this point in the history
remove logger from apis template
  • Loading branch information
nosvalds authored Nov 15, 2022
2 parents f7a02e1 + ad16adf commit 0d5a654
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ Update the Extractor Tool
- Take the previous revision offline.
- Run the extractor tool bash script
- You should see changes to a number of the ARM templates and policies in `./service`
- NOTE: you need to manually remove the object with `"type": "Microsoft.ApiManagement/service/diagnostics"` from the `service/apim-iati-dev-apis.template.json` template, this is covered in the `service/apim-iati-dev-loggers.template.json` template.
- If there are any changes (new parameters) in `service/apim-iati-dev-parameters.json`, ensure that you update the github actions workflows to pass in the new parameters:
- `apim-ci.yml`
- `apim-develop.yml`
Expand Down
16 changes: 0 additions & 16 deletions service/apim-iati-dev-apis.template.json
Original file line number Diff line number Diff line change
Expand Up @@ -9872,22 +9872,6 @@
}
}
},
{
"apiVersion": "2021-08-01",
"type": "Microsoft.ApiManagement/service/diagnostics",
"name": "[concat(parameters('apimServiceName'), '/applicationinsights')]",
"dependsOn": [],
"properties": {
"alwaysLog": "allErrors",
"loggerId": "/subscriptions/bcaf7a00-7a14-4932-ac41-7bb0dee0d2a9/resourceGroups/rg-apim-dev/providers/Microsoft.ApiManagement/service/apim-iati-dev/loggers/appi-apim-dev",
"httpCorrelationProtocol": "Legacy",
"logClientIp": true,
"sampling": {
"samplingType": "fixed",
"percentage": 100.0
}
}
},
{
"apiVersion": "2021-08-01",
"type": "Microsoft.ApiManagement/service/products/apis",
Expand Down

0 comments on commit 0d5a654

Please sign in to comment.