Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 3.1.4 source produces javascript with circular references #71

Open
DrEnter opened this issue Dec 17, 2024 · 1 comment
Open

The 3.1.4 source produces javascript with circular references #71

DrEnter opened this issue Dec 17, 2024 · 1 comment

Comments

@DrEnter
Copy link

DrEnter commented Dec 17, 2024

Description:

The code produced by the current master branch (version 3.1.4) contains circular references. These did not exist with 3.1.1.

Details:

After updating to the 3.1.4 codebase and building the "mjs" javascript, I see the following when I attempt to use it:

(!) Circular dependencies
src/gpp/encoder/section/HeaderV1.js -> src/gpp/encoder/segment/HeaderV1CoreSegment.js -> src/gpp/encoder/section/HeaderV1.js
src/gpp/encoder/section/TcfEuV2.js -> src/gpp/encoder/segment/TcfEuV2CoreSegment.js -> src/gpp/encoder/section/TcfEuV2.js
src/gpp/encoder/section/TcfCaV1.js -> src/gpp/encoder/segment/TcfCaV1CoreSegment.js -> src/gpp/encoder/section/TcfCaV1.js
src/gpp/encoder/section/UspV1.js -> src/gpp/encoder/segment/UspV1CoreSegment.js -> src/gpp/encoder/section/UspV1.js
src/gpp/encoder/section/UsNat.js -> src/gpp/encoder/segment/UsNatCoreSegment.js -> src/gpp/encoder/section/UsNat.js

Will this be fixed with an upcoming release or patch?

@DrEnter
Copy link
Author

DrEnter commented Dec 18, 2024

Commenting to add this additional detail: The issue appears to have first appeared in the 3.1.3 release, with the introduction of the "encoder/segment/*CoreSegment.ts" code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant