Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete a picture from a document #187

Open
petitfa1 opened this issue May 29, 2024 · 5 comments · May be fixed by #210
Open

Delete a picture from a document #187

petitfa1 opened this issue May 29, 2024 · 5 comments · May be fixed by #210
Labels
feature

Comments

@petitfa1
Copy link
Contributor

petitfa1 commented May 29, 2024 •
edited by raphaelweis
Loading

Linked to the feature #153 , for now it's possible to add a picture into a document, but not to delete it.

The idea would be to add a button on each picture allowing the user to delete it from the server.
@Barnabepetit Barnabepetit moved this from Suggéré to En cours in Analyse du système d'information 2024 May 29, 2024
@petitfa1
Copy link
Contributor Author

petitfa1 commented May 29, 2024 •
edited by nitram35
Loading

Phase 1

  • Scenarios (Gherkin)
  • Mockups
  • Implementation strategy

Phase 2

  • Acceptance tests (Capybara)
  • Implementation

Phase 3

  • Screencast

@louisduhalberruer
Copy link
Contributor

louisduhalberruer commented Jun 7, 2024 •
edited by raphaelweis
Loading

Implementation strategy :

  • We looked at how to DELETE attachments from CouchDB using http client such as Postman
  • With this knowledge, we can now implement the UI for deleting pictures, which consists in :
    • adding a delete button on every image, with a confirmation dialog when pressed
    • then making the correct API call to delete an attachment
    • refresh the ui

@Hypertopic Hypertopic deleted a comment from Barnabepetit Jun 12, 2024
@raphaelweis
Copy link
Contributor

raphaelweis commented Jun 12, 2024 •
edited
Loading

Frame 4

Frame 5(1)

Binôme @raphaelweis et @Barnabepetit.

@raphaelweis
Copy link
Contributor

The mockups have been updated because the previous proposition did not allow for multiple images to be in the same block.

nitram35 added a commit that referenced this issue Jun 12, 2024
@nitram35
SCENARIO : Delete a picture from a document (see #187)
396f31f 
Co-Authored-By: Fabien Petit <[email protected]>
nitram35 added a commit that referenced this issue Jun 12, 2024
@nitram35
TEST : Delete a picture from a document (see #187)
a1113cf 
Co-Authored-By: Fabien Petit<[email protected]>
@benel
Copy link
Member

benel commented Jun 15, 2024

@nitram35 and @petitfa1, don't forget to open a draft pull request on your branch (even if is not finished, so that I can review your code).

@nitram35 nitram35 linked a pull request Jun 16, 2024 that will close this issue
Draft
petitfa1 added a commit that referenced this issue Jun 19, 2024
@petitfa1
TEST : Delete a picture from a document (see #187)
b50dc55 
Co-Authored-By: Martin GANDOM<[email protected]>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
@louisduhalberruer @nitram35
SCENARIO : Delete a picture from a document (see #187)
e5af497 
Co-Authored-By: Fabien Petit <[email protected]>
Co-Authored-By: Louis Duhal Berruer <[email protected]>
nitram35 added a commit that referenced this issue Jun 19, 2024
@nitram35
TEST : Delete a picture from a document (see #187)
3b254cd 
Co-Authored-By: Fabien Petit<[email protected]>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
@louisduhalberruer @nitram35
SCENARIO : Delete a picture from a document (see #187)
55cbefa 
Co-Authored-By: Fabien Petit <[email protected]>
Co-Authored-By: Louis Duhal Berruer <[email protected]>
nitram35 added a commit that referenced this issue Jun 19, 2024
@nitram35
TEST : Delete a picture from a document (see #187)
72ca9d9 
Co-Authored-By: Fabien Petit<[email protected]>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
@louisduhalberruer @nitram35
SCENARIO : Delete a picture from a document (see #187)
4d3e2fe 
Co-Authored-By: Fabien Petit <[email protected]>
Co-Authored-By: Louis Duhal Berruer <[email protected]>
nitram35 pushed a commit that referenced this issue Jun 19, 2024
@louisduhalberruer @nitram35
SCENARIO : Delete a picture from a document (see #187)
5f6c867 
Co-Authored-By: Fabien Petit <[email protected]>
Co-Authored-By: Louis Duhal Berruer <[email protected]>
raphaelweis pushed a commit that referenced this issue Jun 19, 2024
@louisduhalberruer @raphaelweis
SCENARIO : Delete a picture from a document (see #187)
40287d0 
Co-Authored-By: Fabien Petit <[email protected]>
Co-Authored-By: Louis Duhal Berruer <[email protected]>
raphaelweis pushed a commit that referenced this issue Jun 19, 2024
@nitram35 @raphaelweis
TEST : Delete a picture from a document (see #187)
a0a1068 
Co-Authored-By: Fabien Petit<[email protected]>
nitram35 added a commit that referenced this issue Jun 19, 2024
@nitram35
SCENARIO : Delete a picture from a document (see #187)
7c3c21e 
Co-Authored-By: Fabien Petit <[email protected]>
nitram35 added a commit that referenced this issue Jun 19, 2024
@nitram35
TEST : Delete a picture from a document (see #187)
f6de2ce 
Co-Authored-By: Fabien Petit<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
No open projects
Analyse du système d'information 2024
Status: En cours
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

187 - Delete a picture from a document Hypertopic/HyperGlosae
4 participants
@benel @louisduhalberruer @raphaelweis @petitfa1