Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that anchors work with multibyte Unicode #441

Open
carlgieringer opened this issue Jul 1, 2023 · 2 comments
Open

Ensure that anchors work with multibyte Unicode #441

carlgieringer opened this issue Jul 1, 2023 · 2 comments
Labels
core domain Entities and core domain/business logic

Comments

@carlgieringer carlgieringer added the core domain Entities and core domain/business logic label Jul 1, 2023
@carlgieringer carlgieringer self-assigned this Jul 2, 2023
@carlgieringer
Copy link
Contributor Author

I think the initial issue was an occurrence of #437 because this link (containing a curly quote and also at the beginning of the page) works: https://www.thefp.com/p/douglas-murray-elizabeth-barrett-browning#:~:text=Elizabeth%20Barrett%20Browning%E2%80%99s%20love%20poem%20is%20famous.%20But%20her%20own%20love%20story%20is%20just%20as%20legendary.

This behavior might also arise from incomplete unicode support in dom-anchor-text-quote (transitively from google/diff-match-patch#80.) This issue will now focus on the Unicode issue.

@carlgieringer carlgieringer changed the title encodeURIComponent produces text fragments incompatible with Chrome Ensure that anchors work with multibyte Unicode Jul 2, 2023
@carlgieringer carlgieringer removed their assignment Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core domain Entities and core domain/business logic
Projects
None yet
Development

No branches or pull requests

1 participant