Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weaviate 1.27.6 (new formula) #199810

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Conversation

Dabz
Copy link

@Dabz Dabz commented Dec 2, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Dec 2, 2024
@chenrui333 chenrui333 changed the title Weaviate 1.27.6 (new formula) weaviate 1.27.6 (new formula) Dec 3, 2024
Formula/w/weaviate.rb Outdated Show resolved Hide resolved
Formula/w/weaviate.rb Outdated Show resolved Hide resolved
Formula/w/weaviate.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot removed the new formula PR adds a new formula to Homebrew/homebrew-core label Dec 3, 2024
@Dabz Dabz closed this Dec 3, 2024
@Dabz Dabz reopened this Dec 3, 2024
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Dec 3, 2024
@Dabz
Copy link
Author

Dabz commented Dec 3, 2024

Thanks for the review @chenrui333!
I fixed all the mentioned points, could you do a new (hopefully final) review?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 3, 2024
Formula/w/weaviate.rb Outdated Show resolved Hide resolved
Formula/w/weaviate.rb Outdated Show resolved Hide resolved
Formula/w/weaviate.rb Outdated Show resolved Hide resolved
@chenrui333
Copy link
Member

can you also squash the commits as well? thanks!

@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 3, 2024
@Dabz
Copy link
Author

Dabz commented Dec 3, 2024

can you also squash the commits as well? thanks!

Done, all squahed

Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Dabz
Copy link
Author

Dabz commented Dec 4, 2024

Thanks a lot @chenrui333 and @daeho-ro !

I let you merge the PR :-)

Copy link
Contributor

github-actions bot commented Dec 4, 2024

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 4, 2024
@BrewTestBot BrewTestBot enabled auto-merge December 4, 2024 12:52
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 4, 2024
Merged via the queue into Homebrew:master with commit 1b79df9 Dec 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants