Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libunicode 0.6.0 (new formula) #198782

Merged
merged 2 commits into from
Dec 2, 2024
Merged

libunicode 0.6.0 (new formula) #198782

merged 2 commits into from
Dec 2, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added new formula PR adds a new formula to Homebrew/homebrew-core autobump labels Nov 24, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Nov 24, 2024
@chenrui333 chenrui333 force-pushed the libunicode branch 2 times, most recently from d797bce to 6bda481 Compare November 24, 2024 01:01
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 24, 2024
@chenrui333 chenrui333 force-pushed the libunicode branch 2 times, most recently from f476ac3 to 7371da8 Compare November 24, 2024 02:40
@chenrui333 chenrui333 requested a review from a team as a code owner November 24, 2024 02:51
@chenrui333
Copy link
Member Author

does not build with system gcc, so adding gcc linux dependency.

@chenrui333 chenrui333 force-pushed the libunicode branch 2 times, most recently from 2ffb90a to 32aa105 Compare November 24, 2024 04:55
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Nov 25, 2024
carlocab
carlocab reviewed Nov 25, 2024
View reviewed changes
Formula/lib/libunicode.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving back to comment based on @carlocab's comment.

@chenrui333 chenrui333 added the macos-only Formula depends on macOS label Dec 1, 2024
@chenrui333 chenrui333 removed the macos-only Formula depends on macOS label Dec 1, 2024
@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label Dec 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

:shipit: @p-linnane has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 2, 2024
@BrewTestBot BrewTestBot enabled auto-merge December 2, 2024 20:40
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit 2d41b16 Dec 2, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the libunicode branch December 2, 2024 20:49
chenrui333
chenrui333 commented Dec 2, 2024
View reviewed changes
Formula/lib/libunicode.rb
sha256 cellar: :any, arm64_ventura: "dcbad1aeabc61e9e4ef5b0776cc40fcaab878e67931bf0b057847e3e9e69e86c"
sha256 cellar: :any, sonoma: "eb839f56e6eb0d2d877a623eeab2ba46fa4a2f8e7c5b6133232caef634f14fb8"
sha256 cellar: :any, ventura: "88b268f809736144bc316d83d38ece5c25c96c4b97b563173a8ca925fccddbc8"
sha256 cellar: :any_skip_relocation, x86_64_linux: "af4677a7a0f6b40d288cb674a70c3c58fccaa970aff7b2ee0d68e5f387c6ce64"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was actually a cached bottle

image

@chenrui333 chenrui333 mentioned this pull request Dec 2, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

@fxcoudert fxcoudert fxcoudert left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@p-linnane p-linnane p-linnane approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
autobump CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chenrui333 @MikeMcQuaid @fxcoudert @carlocab @daeho-ro @p-linnane @BrewTestBot